Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: file:// URLs support #54

Merged
merged 4 commits into from
Mar 21, 2023
Merged

feat: file:// URLs support #54

merged 4 commits into from
Mar 21, 2023

Conversation

diivi
Copy link
Collaborator

@diivi diivi commented Mar 19, 2023 •
edited
Loading

Yet to do (and write) some tests.

witten
witten reviewed Mar 20, 2023
View reviewed changes
borgmatic/borg/export_tar.py Outdated Show resolved Hide resolved
borgmatic/borg/export_tar.py Outdated Show resolved Hide resolved
@diivi diivi marked this pull request as ready for review March 21, 2023 11:36
@witten
Copy link
Collaborator

witten commented Mar 21, 2023

Thanks for making the revisions! This looks good to me.

@witten witten merged commit c83fae5 into borgmatic-collective:master Mar 21, 2023
@witten
Copy link
Collaborator

witten commented Mar 21, 2023

Heads up that I removed an unused import in this that flake8 was complaining about (os in export_tar.py), which subsequently broke tests that were relying on it. These tests were setting up expectations on os.path.abspath(), which wasn't used any longer in export_tar.py after your changes. So I just removed those expectations and now tests pass again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@witten witten witten left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diivi @witten