Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add dump-restore support for sqlite databases #50

Merged
merged 8 commits into from
Mar 4, 2023
Merged

feat: add dump-restore support for sqlite databases #50

merged 8 commits into from
Mar 4, 2023

Conversation

diivi
Copy link
Collaborator

@diivi diivi commented Mar 2, 2023

fixes #295
Will add to e2e tests once I understand how to do so.

witten
witten requested changes Mar 2, 2023
View reviewed changes
Copy link
Collaborator

@witten witten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start! Thank you so much for tackling this ticket. I think this is a much-needed addition to borgmatic's database feature set. Let me know if I can help out at all with the end-to-end tests.

borgmatic/config/schema.yaml Outdated Show resolved Hide resolved
borgmatic/config/schema.yaml Outdated Show resolved Hide resolved
borgmatic/config/schema.yaml Outdated Show resolved Hide resolved
borgmatic/hooks/sqlite.py Outdated Show resolved Hide resolved
borgmatic/hooks/sqlite.py Outdated Show resolved Hide resolved
tests/unit/hooks/test_sqlite.py Outdated Show resolved Hide resolved
tests/unit/hooks/test_sqlite.py Outdated Show resolved Hide resolved
tests/unit/hooks/test_sqlite.py Show resolved Hide resolved
tests/unit/hooks/test_sqlite.py Show resolved Hide resolved
tests/unit/hooks/test_sqlite.py Outdated Show resolved Hide resolved
@diivi diivi marked this pull request as ready for review March 3, 2023 21:25
witten
witten requested changes Mar 4, 2023
View reviewed changes
Copy link
Collaborator

@witten witten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments, but this is looking really good and I think will be ready for merging soon! Thank you.

borgmatic/hooks/sqlite.py Outdated Show resolved Hide resolved
borgmatic/hooks/sqlite.py Outdated Show resolved Hide resolved
tests/end-to-end/test_database.py Show resolved Hide resolved
tests/unit/hooks/test_sqlite.py Show resolved Hide resolved
@diivi diivi requested a review from witten March 4, 2023 07:13
witten
witten requested changes Mar 4, 2023
View reviewed changes
Copy link
Collaborator

@witten witten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last thing and then I think we're all done!

borgmatic/hooks/sqlite.py Show resolved Hide resolved
witten
witten requested changes Mar 4, 2023
View reviewed changes
borgmatic/hooks/sqlite.py Outdated Show resolved Hide resolved
witten
witten approved these changes Mar 4, 2023
View reviewed changes
Copy link
Collaborator

@witten witten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!! It's ready to merge as far as I'm concerned. Thanks again for taking the time.

@witten witten merged commit 9ec220c into borgmatic-collective:master Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@witten witten witten approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@diivi @witten