WIP: Reopen addrepowindow
prefilled when adding repo fails
#1966
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The addRepoWindow now opens prefilled with RepoUrl, name and extraBorgArguments if adding repo fails.
Does not save password due to security reasons, and Encryption because last saved value might no longer be supported on next run of vorta (in case user changes Borg version).
Related Issue
Resolves #1757
Motivation and Context
Add Repo Window does not retain last inputs when adding the repo fails and needs to be filled again.
How Has This Been Tested?
Tested locally by making
process_result
method ofBorgInitJob
raise an error intentionally, to mimic failure in adding repo.Screenshots (if appropriate):
Adding new Repo (which fails):
AddRepoWindow
opens prefilled next time:Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.