feat: assign names to repos

[diivi]

Description

Adds a "name" field in the new repo creation form and displays it where I thought it was suitable.

Related Issue

Fixes #1388

Motivation and Context

Easier to remember and tag repos.

How Has This Been Tested?

Tried creating a repo and looking at the places where I rendered the name instead of the url.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• I have read the CONTRIBUTING guide.
• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

[real-yfprojects]

I think the repo id should be used when the user didn't specify a repo name.

[m3nu]

I'd still show the repo URL behind the name in the dropdown and on the archives tab. Maybe My Macbook BorgBase Repo – ssh://[email protected]

And have "optional" in the placeholder. E.g. Some name (optional). To clarify 1) that this is optional and 2) that this is used only locally to manage the repo. Maybe there is better wording for it.

[real-yfprojects]

I think a tooltip showing the complete repo path would be useful since it sometimes doesn't fit into the displaying widget.

[real-yfprojects]

Looking good. However I am unsure whether I like using the repo id as a repo name for existing repos. I don't see any value in having 1,2,3 and so on in front of my repo paths/urls. I believe its better to only show the name if the user specified one.

And we should provide a way to edit the repo name. This could be a task for a future PR.

[m3nu]

Implementation looks good and it does what it promises.

Just have one idea to make it even better: How about adding some space or a thin line before the 2 password fields? To slightly separate them from the other fields and have a logical grouping.

[diivi]

With separators (2e27718)

[m3nu]

I think it's great like this.

[real-yfprojects]

I propose this, in accordance to the HIG:

[m3nu]

This is OK to merge for me, but has pending feedback from @real-yfprojects regarding the small UI thing.

[diivi]

I propose this, in accordance to the HIG:

Can you share the code/property?

[diivi]

Ignore the black eye icon, it seems to be an issue with the master branch as well, I will file it.

[m3nu]

Right. I had to update some icons due to licensing and forgot to adjust the fill property for those. Please adjust it by adding fill="#000000" in the first <svg> tag:

<svg version="1.1" id="Layer_1" xmlns="http://www.w3.org/2000/svg" xmlns:xlink="http://www.w3.org/1999/xlink" x="0px" y="0px" viewBox="0 0 1536 1536" style="enable-background:new 0 0 1536 1536;" fill="#000000" xml:space="preserve">

This is needed for all icons, so they can be colored light/dark.

I still need to make a change for Google's Material icons license, so could also make the change there, if it doesn't fit this PR.

[diivi]

Done

[m3nu]

Thanks for sneaking this in. Will test locally in a few hours and then merge.

[m3nu]

Works as expected locally and implementation looks reasonable.

Congrats on another successful PR, @diivi 👏