Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add settings to retain sort by column and order in source tab #1649

Merged
merged 5 commits into from
Apr 4, 2023

Conversation

jetchirag
Copy link
Contributor

Description

Adds two new settings to retain the sort by details in source tab

  • sourcetab_sort_column
  • sourcetab_sort_order

Related Issue

Fixes #1647

Motivation and Context

Retains the sort by details to improve UX

How Has This Been Tested?

Tested all the columns and order sort method by reopening application and debug logging

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have read the CONTRIBUTING guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

Copy link
Collaborator

@real-yfprojects real-yfprojects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm. Will test later.

Add type annotations to update_sort_order function parameters

Co-authored-by: yfprojects <[email protected]>
@real-yfprojects real-yfprojects requested a review from m3nu March 14, 2023 08:08
@m3nu m3nu merged commit 6d5e738 into borgbase:master Apr 4, 2023
diivi pushed a commit to diivi/vorta that referenced this pull request Apr 11, 2023
DaffyTheDuck pushed a commit to DaffyTheDuck/vorta that referenced this pull request Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants