Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add settings for files list views #1621

Merged
merged 12 commits into from
Apr 5, 2023

Conversation

diivi
Copy link
Contributor

@diivi diivi commented Mar 2, 2023

Added two settings to remember user's preferred files list view in the diff and extract dialogs

  • extract_files_display_mode
  • diff_files_display_mode

fixes #1516

Motivation and Context

Improves UX

How Has This Been Tested?

Tested by changing the views and reopening vorta.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING guide.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

I have to update the tests, then I'll make this ready for review.

I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.

@diivi diivi marked this pull request as ready for review March 2, 2023 21:23
@diivi diivi requested a review from real-yfprojects March 5, 2023 18:16
src/vorta/views/diff_result.py Outdated Show resolved Hide resolved
src/vorta/views/diff_result.py Outdated Show resolved Hide resolved
@diivi diivi requested a review from real-yfprojects March 11, 2023 10:33
Copy link
Collaborator

@real-yfprojects real-yfprojects left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected! Thank you.

@m3nu m3nu merged commit b51b1ef into borgbase:master Apr 5, 2023
diivi added a commit to diivi/vorta that referenced this pull request Apr 11, 2023
* feat: add a setting for files list views

* separate logic from data class

* make mode optional

* rename display mode methods

* refactor

* move code above connect signals comment

* reorder code

---------

Co-authored-by: yfprojects <[email protected]>
Co-authored-by: Manu <[email protected]>
DaffyTheDuck pushed a commit to DaffyTheDuck/vorta that referenced this pull request Jun 14, 2023
* feat: add a setting for files list views

* separate logic from data class

* make mode optional

* rename display mode methods

* refactor

* move code above connect signals comment

* reorder code

---------

Co-authored-by: yfprojects <[email protected]>
Co-authored-by: Manu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display mode of diff view should be remembered as setting when restarting Vorta
3 participants