feat: add link to the logs folder in borg warnings #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
What purpose serves the last commit? You don't have to modify any translation files. That's all done automatically in preparation of a release. There is a rule for that in our make file.
You will need to use translate instead of trans_late else the translations won't be loaded at runtime. Please tell me if any part of the contributing docs is unclear.
This reverts commit dfc5bff.
real-yfprojects
previously approved these changes
Mar 2, 2023
…/vorta into feat/link-logs-in-warnings
m3nu
requested changes
Mar 6, 2023
…k-logs-in-warnings
…/vorta into feat/link-logs-in-warnings
|
@diivi Can you rebase onto master and adjust this PR. |
real-yfprojects
approved these changes
Mar 11, 2023
ThomasWaldmann
approved these changes
Mar 11, 2023
diivi
added a commit
to diivi/vorta
that referenced
this pull request
Apr 11, 2023
In case a borg job finishes with warning, vorta will display it and tell the user to have a look in the logs. This adds a clickable link to the log message that opens the default file explorer at the log location. * src/vorta/application.py (VortaApp.check_failed_response): Improve wording of warning message and link logs. * src/vorta/borg/create.py (BorgCreateJob.process_result): Link logs. * src/vorta/borg/compact.py (BorgCompactJob.finished_event): ^^ * src/vorta/borg/check.py (BorgCheckJob.finished_event): ^^ * src/vorta/assets/UI/mainwindow.ui : Enable `openExternalLinks` for `progressText` label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a link to the vorta logs folder on the user's device in the
progressTextqLabel.Please let me know in what state I should leave the strings for translation, thanks.
Related Issue
#1486
Motivation and Context
Easier to open the logs folder without having to look for it (better UX).
Screenshots (if appropriate):
Types of changes
Checklist:
I provide my contribution under the terms of the license of this repository and I affirm the Developer Certificate of Origin.