Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split message filtering functionality into distinct operators #64

Merged
merged 7 commits into from
Jun 27, 2023

Conversation

glopesdev
Copy link
Member

@glopesdev glopesdev commented Jun 22, 2023

This PR deprecates the existing FilterMessage operator and introduces two new operators: FilterMessageType which is a general operator that can work for all messages; and FilterRegister which can be extended by different device packages to filter device-specific messages.

Both of these operators expose a FilterType property specifying whether the filter includes or excludes all messages matching its criteria. For consistency, we also drop the message type property from the Parse operators. The filter in Parse is always inclusive-only since Parse cannot promise to know how to handle arbitrary messages outside its specified register.

Fixes #61

@glopesdev glopesdev added the feature New planned feature label Jun 22, 2023
@glopesdev glopesdev added this to the 3.5 milestone Jun 22, 2023
@glopesdev glopesdev merged commit 37ecce6 into bonsai-rx:main Jun 27, 2023
@glopesdev glopesdev deleted the issue-61 branch June 27, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New planned feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split FilterMessage into distinct pattern matching operators
1 participant