Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for streaming binary serial read buffers #1456

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

glopesdev
Copy link
Member

@glopesdev glopesdev commented Jul 5, 2023

This PR adds support for continuous streaming of fixed size buffers from the low-level SerialRead operator. This makes SerialRead work symmetrically with the SerialReadLine operator. Furthermore we adapted the triggered interface to use the Read methods from serial port for parity with SerialReadLine usage and to allow for interleaving binary and text operators.

Care should be taken to ensure that the binary stream is correctly aligned. Cancellation of blocking operations is supported but the serial port will not be closed until the corresponding subscription to CreateSerialPort is cancelled, or all operators accessing the serial port are cancelled.

@glopesdev glopesdev added the feature New planned feature label Jul 5, 2023
@glopesdev glopesdev added this to the 2.8 milestone Jul 5, 2023
@glopesdev glopesdev merged commit 2e76051 into bonsai-rx:main Jul 5, 2023
@glopesdev glopesdev deleted the streaming-serialread branch July 5, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New planned feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant