Ensure single subscription to Gate opening events #1315
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the behavior of the
Gate
operator to be consistent with common language patterns re. subscription. TheGate
operator in Rx can be called either with a factory overload, where a new subscription is created for each gate trigger, or with a single subscription to an event sequence, where each notification triggers the gate.The latter overload is more consistent with the rules of similar operators such as
WindowTrigger
. In general one can use theDefer
operator if the former behavior is required. Alternatively, a new variant of theGate
operator can be exposed in the future which surfaces the factory overload through a nested operator.Fixes #1206