Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workflows running from the command line do not terminate the process on completion #1740

Closed
glopesdev opened this issue Apr 15, 2024 · 0 comments · Fixed by #1755
Closed

Workflows running from the command line do not terminate the process on completion #1740

glopesdev opened this issue Apr 15, 2024 · 0 comments · Fixed by #1755
Labels
bug Something isn't working critical This is a blocking issue affecting all users
Milestone
2.8.3

Comments

@glopesdev
Copy link
Member

This was a regression likely introduced on release of 2.8.0 with the change to use inter-process communication instead of AppDomains for isolating workflow execution.

To reproduce:

bonsai.exe --no-editor emptyWorkflow.bonsai
@glopesdev glopesdev added bug Something isn't working critical This is a blocking issue affecting all users labels Apr 15, 2024
@glopesdev glopesdev added this to the 2.8.3 milestone Apr 15, 2024
@PathogenDavid PathogenDavid mentioned this issue Apr 23, 2024
Merged
PathogenDavid added a commit to PathogenDavid/bonsai that referenced this issue Apr 23, 2024
@PathogenDavid
Fix workflows run from the command line not exiting upon completion.
d0e74e9 
This also indirectly fixes exceptions during cleanup getting swallowed unceremoniously.
Also fixes leaked NotifyIcon.

Fixes bonsai-rx#1740
@PathogenDavid PathogenDavid mentioned this issue Apr 23, 2024
Merged
PathogenDavid added a commit to PathogenDavid/bonsai that referenced this issue Apr 24, 2024
@PathogenDavid
Fix workflows run from the command line not exiting upon completion.
4ef69e9 
This also indirectly fixes exceptions during cleanup getting swallowed unceremoniously.
Also fixes leaked NotifyIcon.

Fixes bonsai-rx#1740
@glopesdev glopesdev mentioned this issue May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working critical This is a blocking issue affecting all users
Projects
None yet
Milestone
2.8.3
Development

Successfully merging a pull request may close this issue.

Fix workflows run from the command line not exiting upon completion PathogenDavid/bonsai
1 participant
@glopesdev