Skip to content

⬆️ Upgrade dependency nesbot/carbon - issue #3551 #3554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

⬆️ Upgrade dependency nesbot/carbon - issue #3551 #3554

wants to merge 1 commit into from

Conversation

macintoshplus
Copy link
Contributor

See issue #3551

@macintoshplus macintoshplus mentioned this pull request Mar 11, 2025
Open
19 tasks
bobvandevijver
bobvandevijver requested changes Mar 11, 2025
View reviewed changes
Copy link
Member

@bobvandevijver bobvandevijver left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, check your PRs before submitting and make sure they only contain what is needed. This one bleeds code from your other PR and has unrelated changes.

@macintoshplus macintoshplus force-pushed the issue_3551_upgrade_carbon branch 2 times, most recently from 103ca49 to 6dcecd8 Compare March 11, 2025 23:29
@macintoshplus
Copy link
Contributor Author

Please, check your PRs before submitting and make sure they only contain what is needed. This one bleeds code from your other PR and has unrelated changes.

Sorry, I have reverted unrelated changes

@macintoshplus macintoshplus added the dependencies Pull requests that update a dependency file label Mar 11, 2025
@macintoshplus macintoshplus force-pushed the issue_3551_upgrade_carbon branch from 6dcecd8 to a9703cc Compare March 12, 2025 09:42
@macintoshplus macintoshplus force-pushed the issue_3551_upgrade_carbon branch from a9703cc to 7c0e7fa Compare March 14, 2025 10:43
@macintoshplus
Copy link
Contributor Author

I have rebased. This PR is ready to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobvandevijver bobvandevijver Awaiting requested review from bobvandevijver

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@macintoshplus @bobvandevijver