Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove collection item if the user accepts #3265

Merged
merged 2 commits into from
Jul 5, 2022
Merged

Remove collection item if the user accepts #3265

merged 2 commits into from
Jul 5, 2022

Conversation

nestordedios
Copy link
Collaborator

Fixes #3264

Detect if the save button is clicked and remove the collection item then.

bobdenotter
bobdenotter approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoop whoop!

@bobdenotter bobdenotter merged commit d92a33f into master Jul 5, 2022
@bobdenotter bobdenotter deleted the fix/remove-collection-items branch July 5, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collection items get removed before accepting or denying action
2 participants
@nestordedios @bobdenotter