Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renamed the Icon method in the Content class #3198

Merged
merged 1 commit into from
May 23, 2022
Merged

Renamed the Icon method in the Content class #3198

merged 1 commit into from
May 23, 2022

Conversation

Spomsoree
Copy link
Contributor

@Spomsoree Spomsoree commented May 6, 2022 •
edited
Loading

to avoid name conflicts with fields named icon.

With the current naming it's impossible to name a field icon and access it in twig.

bobdenotter
bobdenotter approved these changes May 23, 2022
View reviewed changes
Copy link
Member

@bobdenotter bobdenotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this earlies, my apologies!

Thanks, @Spomsoree 👍

@bobdenotter bobdenotter merged commit e71625f into bolt:master May 23, 2022
@bobdenotter bobdenotter mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobdenotter bobdenotter bobdenotter approved these changes

Assignees
No one assigned
Labels
🐛 tag: bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Spomsoree @bobdenotter