Add is_numerical check - See #6995
#7010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GwendolenLynch
approved these changes
Sep 19, 2017
GwendolenLynch
suggested changes
Sep 19, 2017
src/Config.php
Outdated
| @@ -356,6 +356,9 @@ protected function parseTaxonomy() | |||
| if (!empty($taxonomy['options']) && is_array($taxonomy['options'])) { | |||
| $options = []; | |||
| foreach ($taxonomy['options'] as $optionKey => $optionValue) { | |||
| if (is_numeric($optionKey)) { | |||
| $optionKey = $optionValue; | |||
| } | |||
There was a problem hiding this comment.
Oh wait, that will need to go below the line, um, below this … as the value should be slugged.
There was a problem hiding this comment.
New tests say you were right 😉
|
In the table, you save a slug and a value. The value should not be slugified, right? |
GwendolenLynch
approved these changes
Sep 19, 2017
Yeah, I was getting lost in the sea of logic in that method … hence the tests 😉 |
GwendolenLynch
added a commit
that referenced
this pull request
Sep 19, 2017
Add `is_numerical` check for taxonomy options
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #6995 .
The numerical check is still required because you can define taxonomies as:
and
The code before this pull, would actually save it as: