Better feedback when Records can't be saved. #5801
Conversation
| if ($this->app['request']->isXmlHttpRequest()) { | ||
| $response = ['error' => ['message' => 'Redirect detected. Check if you are still logged on.'] ]; | ||
| return new JsonResponse($response, 500); | ||
| } |
There was a problem hiding this comment.
Wrong approach mate. This will affect all AJAX requests requiring a redirect and none would be valid.
There was a problem hiding this comment.
Currently, all 'ajaxy' requests that will redirect will fail silently. What happens is that it gets redirected, and returns an HTML page of the login screen, with a 200 status. As far as I can tell these just fail silently, and in javascript the .done() or .success() will be triggered, which is not correct.
This change will send a 500, so in the requesting javascript it can be caught. At the very least it'll trigger the .fail() method, allowing us to give feedback to the user.
There was a problem hiding this comment.
👍 for using proper error codes!
bobdenotter
changed the title
|
As mentioned in #5803, I've also updated the icon in the save button, to reflect a successful or failed save: Failure: Success: http://recordit.co/YBxyHjHC2J |
bobdenotter
changed the title
|
🎉 merging… |
Fixes #5788
Fixes #5803
When saving a record fails, you'll get a more visible error message now. See:
http://recordit.co/eeeYMiT986
Screenshot of an actual Bolt error occurring: