Fix slash in taxonomies

[SvanteRichter]

Fixes #5673

In taxonomy slugs we basically allow any character (since we do not slugify them). One way to test this is to add a tag with a bunch of special chars or with a taxonomy like this:

categories:
    name: Categories
    slug: categories
    singular_name: Category
    singular_slug: category
    behaves_like: categories
    options: {'test&%¤': test}

The only character that we cannot use or have is a slash since that denotes a separation of url portions.

This PR removes any slash found in a taxonomy slug (since that's how we do it in record slugs) and shows a warning flash message if a slash is put in a slug in taxonomy.yml.

PRing into 3.0 since this is a bug fix, let me know if I should retarget to 3.1.

[GwendolenLynch]

PSR-2 on the variable name case.

Also the nesting is a tad aggressive… Does this read better to you on review?

    public function checkTaxonomy()
    {
        foreach ($this->data['taxonomy'] as $key => $taxonomy) {
            if (empty($taxonomy['options']) || !is_array($taxonomy['options'])) {
                continue;
            }

            foreach ($taxonomy['options'] as $optionKey => $optionValue) {
                if (strpos($optionKey, '/') === false) {
                    continue;
                }

                $error = Trans::__(
                    'general.phrase.invalid-taxonomy-slug',
                    ['%taxonomy%' => $key, '%option%' => $optionValue]
                );
                $this->app['logger.flash']->error($error);
            }
        }
    }

[GwendolenLynch]

Just flagging for the a.m.

This is not the place to be doing/firing this …

[SvanteRichter]

Well, where is the right place? I didn't really know where to put it, so I followed the checkConfig way of doing things, and assumed that following established code was the way to go until we actually get to the config refactor. That way it's more predictable, no?

[GwendolenLynch]

Not sure yet, was mid-wife-night and just noticed this walking past my screen … let me look post- ☕

[GwendolenLynch]

OK … so after looking at it, and thinking about it … probably best for now to put that at the end of checkConfig() as that is one of the things on my 🔥 list for the 3.2 exception/request work.

Short version is that we're checking on every request the configuration of the configuration … ConfigCeption … that is already cached … if it is cached, then we know it's already passed checks.

[GwendolenLynch]

Also moving the call means we can make that function private and not expose another API

[GwendolenLynch]

c.f. master...GawainLynch:hotfix/config-check-request

Note that branch is for master (3.2), but you should get the idea on direction.

[GwendolenLynch]

Green it is going, it is …