Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font-awesome.css.erb #182

Closed
wants to merge 1 commit into from
Closed

Update font-awesome.css.erb #182

wants to merge 1 commit into from

Conversation

washu
Copy link

@washu washu commented Apr 7, 2017

add version value to the url so it matches upstream fontawsome changes to the delcation to work around ipad issues

add version value to the url so it matches upstream fontawsome changes to the delcation to work around ipad issues
@rmm5t
Copy link
Collaborator

rmm5t commented Apr 7, 2017

so it matches upstream fontawsome changes

Could you please provide a link to the specific upstream changes that your referring to?

Adding ?v=x.y.z cache busters should have no effect on Mobile Safari. The font_path helper already constructs a custom cache buster via the asset pipeline. Could you please elaborate on the underlying problem that you're experiencing?

Please review #174 and #175 for more about why we removed those ?v= cache busters.

@rmm5t
Copy link
Collaborator

rmm5t commented Apr 28, 2017

Closing this due to lack of follow-up.

@rmm5t rmm5t closed this Apr 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants