Processing overhaul #173
Merged
Processing overhaul #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both places and organizations are in the same authority file, so it is more efficient to have one script to process that, which will be places.xquery. See #148.
Instead of hardcoding in the XQuery.
Will allow searching for "Composite manuscript".
Will allow advanced search by language across both indexes.
They'll still be indexed as fulltext, but this might reduce the ranking of manuscripts versus people, works, etc, possibly helping with #158
For example, if no xml:id has been given to a manuscript's root TEI element.
In case filter wanted in works, like in Fihrist.
Get associations from works authority files as well as manuscript TEI files. See #79.
In work/person/place pages, see #123
This doesn't work very well in a search across everything so restoring what is on productions. Could add a separate type facet in the future.
So, links to works by their title, authors by their name, etc.
Warnings logged first, before the info messages. Also more concise messages.
Seem to have been lost when merging branches.
holfordm
approved these changes
Aug 13, 2018
|
Great. I forgot to mention, make sure you switch back to the master branch now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Approving this pull request will:
Fix #34
Fix #79
Fix #105
Fix #123
Fix #124
Fix #127
Fix #132
Fix #144
Fix #147
Fix #148
Fix #155
Fix #156
Fix #157
Fix #158
Fix #172
Some of the above require simultaneous changes to the Blacklight configuration, which are controlled by a different, private repository on our internal GitLab system.
So please switch your local copy to the processing-overhaul branch and try running index-all-qa.sh.
If that works, come back here and approve the pull request but do not run index-all-prd.sh.
Then tell me when you are ready to index to production (which will include publishing Merton and all your other recent changes as well as the above fixes and enhancements). I'll then run index-all-prd.sh and deploying the Blacklight configuration at the same time. After that, you'll be able to run it anytime you want.