Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to compile with current nightly #112

Closed
dignifiedquire opened this issue Apr 12, 2020 · 3 comments
Closed

Fails to compile with current nightly #112

dignifiedquire opened this issue Apr 12, 2020 · 3 comments

Comments

@dignifiedquire
Copy link

  • rustc --version rustc 1.44.0-nightly (94d346360 2020-04-09)

Likely a bug in the nightly compiler, but maybe already known here? All working fine on 1.42.

   Compiling typed-html v0.2.2 (/Users/dignifiedquire/opensource/typed-html/typed-html)
error: overflow representing the type `std::option::Option<&T>`

error: aborting due to previous error

error: overflow representing the type `std::option::Option<&T>`

error: aborting due to previous error

error: could not compile `typed-html`.
@chrysn
Copy link
Contributor

chrysn commented Apr 22, 2020

I'm reported this as a Rust error at rust-lang/rust#71359.

The current workaround (and possibly acceptable solution to be applied here) is to increase the recursion limit of typed-html to 130 (or 256 right away).

chrysn added a commit to chrysn-pull-requests/typed-html that referenced this issue Apr 22, 2020
@chrysn
Increase recursion limit
1720eb0 
Changes[1] to the Rust standard library are affecting[2] the nesting
size of types to the point where typed-html can not be built on nightly.

This resolves the issue by increasing the acceptable recursion depth for
the crate.

[1]: rust-lang/rust#70896
[1]: rust-lang/rust#71359

Closes: bodil#112
chrysn added a commit to chrysn-pull-requests/typed-html that referenced this issue Apr 22, 2020
@chrysn
Increase recursion limit
99265c8 
Changes[1] to the Rust standard library are affecting[2] the nesting
size of types to the point where typed-html can not be built on nightly.

This resolves the issue by increasing the acceptable recursion depth for
the crate.

[1]: rust-lang/rust#70896
[2]: rust-lang/rust#71359

Closes: bodil#112
@chrysn chrysn mentioned this issue Apr 22, 2020
Closed
@chrysn
Copy link
Contributor

chrysn commented Apr 24, 2020

The vec reimplementation of the offending Event interator (in #117) appears to achieve the same; applying either makes things buildable in nightly.

@bodil
Copy link
Owner

bodil commented Apr 24, 2020

I went with #117, which should scale better.

@bodil bodil closed this as completed Apr 24, 2020
@elidupree elidupree mentioned this issue Feb 6, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase recursion limit chrysn-pull-requests/typed-html
3 participants
@bodil @chrysn @dignifiedquire