Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement compare functionality and some more traits #82

Merged
merged 6 commits into from
Jul 18, 2024

Conversation

nekevss
Copy link
Member

@nekevss nekevss commented Jul 16, 2024

This adds some compare functions to Date and DateTime, and Ordering for ZonedDateTime.

The compare functions are notably different from Eq and PartialEq as they compare the internal ISO representation ignoring the Calendar

@nekevss nekevss added C-api Changes related to the public API C-enhancement New feature or request labels Jul 16, 2024
@nekevss nekevss force-pushed the add-compare-impls branch from 7ba6d44 to 1037f97 Compare July 18, 2024 00:22
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@nekevss nekevss merged commit 2e6750a into main Jul 18, 2024
5 checks passed
@jedel1043 jedel1043 deleted the add-compare-impls branch July 18, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-api Changes related to the public API C-enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants