Extract temporal tests from the test262 suite #41
Conversation
jedel1043
added
C-enhancement
| @@ -0,0 +1,26 @@ | |||
| [package] | |||
There was a problem hiding this comment.
We can add the publish = false to the [package] to ensure we don't accidentally publish it :)
| } else if let JsValue::Integer(i) = value { | ||
| Ok(*i) |
There was a problem hiding this comment.
We should also check if it's a float that holds a integer value, otherwise values like 1.0 will be considered not integral.
Also I don't know what are the requirement but even values that are bigger that i32::MAX that don't have a fractional part are considered integral in the spec, so we may want to take care of that.
| let years: i32 = args.get_or_undefined(1).try_js_into(context)?; | ||
| let months: i32 = args.get_or_undefined(2).try_js_into(context)?; | ||
| let weeks: i32 = args.get_or_undefined(3).try_js_into(context)?; | ||
| let days: i32 = args.get_or_undefined(4).try_js_into(context)?; | ||
| let hours: i32 = args.get_or_undefined(5).try_js_into(context)?; | ||
| let minutes: i32 = args.get_or_undefined(6).try_js_into(context)?; | ||
| let seconds: i32 = args.get_or_undefined(7).try_js_into(context)?; | ||
| let milliseconds: i32 = args.get_or_undefined(8).try_js_into(context)?; | ||
| let microseconds: i32 = args.get_or_undefined(8).try_js_into(context)?; | ||
| let nanoseconds: i32 = args.get_or_undefined(9).try_js_into(context)?; |
There was a problem hiding this comment.
Same with to_integer_if_integral the TryFromJs trait for i32 doesn't seem to be checking for floating point values that are integers.
This seem like an unrelated bug in TryFromJs that should be solved by boa-dev/boa#3761, but maybe we should account for it here, it maybe causing some test to not generate?
| /// Reads the metadata from the input test code. | ||
| fn read_metadata(test: &Path) -> Result<MetaData> { | ||
| use regex::bytes::Regex; | ||
|
|
||
| /// Regular expression to retrieve the metadata of a test. | ||
| static META_REGEX: OnceLock<Regex> = OnceLock::new(); | ||
|
|
||
| let code = fs::read_to_string(test)?; | ||
|
|
||
| let yaml = META_REGEX | ||
| .get_or_init(|| { | ||
| Regex::new(r"/\*\-{3}((?:.|\n)*)\-{3}\*/") | ||
| .expect("could not compile metadata regular expression") | ||
| }) | ||
| .captures(code.as_bytes()) | ||
| .ok_or_eyre("missing metadata for test")? | ||
| .get(1) | ||
| .map(|m| String::from_utf8_lossy(m.as_bytes())) | ||
| .ok_or_eyre("invalid metadata for test")? | ||
| .replace('\r', "\n"); | ||
|
|
||
| serde_yaml::from_str(&yaml).map_err(Into::into) | ||
| } |
There was a problem hiding this comment.
I think we have a better version on main: https://github.com/boa-dev/boa/blob/main/tests/tester/src/read.rs#L218-L231
We may want to extract the tester to it's own repository at some point, it's easier now that we have the test262 running nightly on data repository, to avoid having so much duplicate code 😅
Just a POC for now, and only generates tests for
Duration::add, but theoretically with the correct glue code we could transform all Temporal tests into a better format for us.Still need to setup the workspace for it.