Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does run!
Nodes implement
CodeGen
which generates instructions onto a stack held in Context.The
VM
will interpret the instructions from Context.There are some issues:
ctx
andctx.instructions
together without it moaning about "mutable borrowing" twice.As most of this is behind a feature flag it would be good to merge parts of it so we can work on as the main interpreter is active. Then one day we can switch over.
for
The instructions generated are
We can optimize even further here and just do the addition at CodeGen level and throw 4 onto the stack
Fixes #167
@Razican @HalidOdat