-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fast path for number to JsString
conversion
#4054
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4054 +/- ##
==========================================
+ Coverage 47.24% 52.95% +5.71%
==========================================
Files 476 484 +8
Lines 46892 47201 +309
==========================================
+ Hits 22154 24997 +2843
+ Misses 24738 22204 -2534 ☔ View full report in Codecov by Sentry. |
Main:
This branch:
|
The change looks good! @CrazyboyQCD can you rebase this on main? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Looks good to me! :)
This removes the intermediate
String
toJsString
conversion.