Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a JsPromise::from_result for convenience #4039

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Nov 11, 2024

No description provided.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 52.88%. Comparing base (6ddc2b4) to head (51fdfab).
Report is 290 commits behind head on main.

Files with missing lines Patch % Lines
core/engine/src/object/builtins/jspromise.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4039      +/-   ##
==========================================
+ Coverage   47.24%   52.88%   +5.64%     
==========================================
  Files         476      483       +7     
  Lines       46892    46947      +55     
==========================================
+ Hits        22154    24829    +2675     
+ Misses      24738    22118    -2620     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nekevss nekevss requested a review from a team November 12, 2024 00:37
@nekevss nekevss added builtins PRs and Issues related to builtins/intrinsics API labels Nov 12, 2024
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nekevss nekevss requested a review from a team November 12, 2024 01:49
@jedel1043 jedel1043 added this pull request to the merge queue Nov 12, 2024
Merged via the queue into boa-dev:main with commit e892d94 Nov 12, 2024
14 checks passed
@raskad raskad added this to the next-release milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API builtins PRs and Issues related to builtins/intrinsics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants