Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TextEncoder, TextDecoder implementations to boa_runtime #3994

Merged
merged 3 commits into from
Sep 19, 2024
Merged

Add TextEncoder, TextDecoder implementations to boa_runtime #3994

merged 3 commits into from
Sep 19, 2024

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Sep 11, 2024

No description provided.

@hansl hansl changed the title Add a TextEncoder implementation to boa_runtime Add TextEncoder, TextDecoder implementations to boa_runtime Sep 11, 2024
jedel1043
jedel1043 approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Seeing that we'll keep increasing the number of WebAPI things in boa_runtime maybe it'll be worth adding a global function boa_runtime::register to add all the builtins into the global object.

@jedel1043 jedel1043 requested a review from a team September 15, 2024 19:00
@jedel1043 jedel1043 added enhancement New feature or request API labels Sep 15, 2024
@jedel1043 jedel1043 added this to the next-release milestone Sep 16, 2024
raskad
raskad approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@raskad raskad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@raskad raskad added this pull request to the merge queue Sep 19, 2024
Merged via the queue into boa-dev:main with commit ddb1901 Sep 19, 2024
13 checks passed
@hansl hansl deleted the text-encoder branch September 21, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raskad raskad raskad approved these changes

@jedel1043 jedel1043 jedel1043 approved these changes

Assignees
No one assigned
Labels
API enhancement New feature or request
Projects
None yet
Milestone
v0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hansl @raskad @jedel1043