Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump intrusive collections #3992

Closed

Conversation

mattsse
Copy link
Contributor

@mattsse mattsse commented Sep 9, 2024

with the newest intrusive-collections release this is currently causing issues

Amanieu/intrusive-rs@5c1cf18

/Users/Matthias/.cargo/registry/src/index.crates.io-6f17d22bba15001f/boa_engine-0.19.0/src/builtins/atomics/futex.rs:161:37
|
161 | pub(crate) static CRITICAL_SECTION: Mutex = Mutex::new(FutexWaiters {
| ^^^^^^^^^^^^^^^^^^^ Cell<std::option::Option<NonNull<LinkedListLink>>> cannot be shared between threads safely
|
= help: within FutexWaiter, the trait Sync is not implemented for Cell<std::option::Option<NonNull<LinkedListLink>>>, which is required by Mutex<FutexWaiters>: Sync
= note: if you want to do aliasing and mutation between multiple threads, use std::sync::RwLock

but it looks like this is no longer an issue on main because it looks like this is compiling
ref #3984

@jedel1043
Copy link
Member

Closing since dependabot already bumped the library.

@jedel1043 jedel1043 closed this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants