Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for boa(rename = "") in TryFromJs derive #3980

Merged
merged 3 commits into from
Sep 5, 2024

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Sep 4, 2024

No description provided.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 51.85%. Comparing base (6ddc2b4) to head (753d3be).
Report is 247 commits behind head on main.

Files with missing lines Patch % Lines
core/macros/src/lib.rs 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3980      +/-   ##
==========================================
+ Coverage   47.24%   51.85%   +4.61%     
==========================================
  Files         476      468       -8     
  Lines       46892    45305    -1587     
==========================================
+ Hits        22154    23493    +1339     
+ Misses      24738    21812    -2926     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jedel1043 jedel1043 requested a review from a team September 5, 2024 04:26
@jedel1043 jedel1043 added enhancement New feature or request API labels Sep 5, 2024
@jedel1043 jedel1043 added this to the next-release milestone Sep 5, 2024
Copy link
Member

@nekevss nekevss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@nekevss nekevss added this pull request to the merge queue Sep 5, 2024
Merged via the queue into boa-dev:main with commit 0f282f5 Sep 5, 2024
14 checks passed
hansl added a commit to hansl/boa that referenced this pull request Sep 12, 2024
* Add support for boa(rename = "") in TryFromJs derive

* Fix clippies and fmt

* Move macro test to boa_engine
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants