Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clippy for denying print and eprints #3967

Merged
merged 3 commits into from
Aug 21, 2024

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Aug 21, 2024

And remove usage of println or allow them.

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.06%. Comparing base (6ddc2b4) to head (612a6fd).
Report is 238 commits behind head on main.

Files Patch % Lines
core/runtime/src/console/mod.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3967      +/-   ##
==========================================
+ Coverage   47.24%   52.06%   +4.81%     
==========================================
  Files         476      468       -8     
  Lines       46892    45099    -1793     
==========================================
+ Hits        22154    23480    +1326     
+ Misses      24738    21619    -3119     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nekevss nekevss added the Internal Category for changelog label Aug 21, 2024
@nekevss nekevss requested a review from a team August 21, 2024 01:47
Copy link
Member

@jedel1043 jedel1043 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just have a small nitpick.

Cargo.toml Outdated Show resolved Hide resolved
@hansl hansl requested a review from jedel1043 August 21, 2024 16:12
@jedel1043 jedel1043 requested a review from a team August 21, 2024 17:08
@jedel1043 jedel1043 added this to the next-release milestone Aug 21, 2024
@nekevss nekevss added this pull request to the merge queue Aug 21, 2024
Merged via the queue into boa-dev:main with commit 1c1d820 Aug 21, 2024
14 checks passed
@hansl hansl deleted the clippy-prevent-println branch August 21, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internal Category for changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants