Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow trailing commas in js_class functions #3964

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

hansl
Copy link
Contributor

@hansl hansl commented Aug 20, 2024

They're ignored.

Copy link

codecov bot commented Aug 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.06%. Comparing base (6ddc2b4) to head (8d6dcc5).
Report is 237 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3964      +/-   ##
==========================================
+ Coverage   47.24%   52.06%   +4.81%     
==========================================
  Files         476      468       -8     
  Lines       46892    45101    -1791     
==========================================
+ Hits        22154    23481    +1327     
+ Misses      24738    21620    -3118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jedel1043 jedel1043 added enhancement New feature or request API labels Aug 21, 2024
@jedel1043 jedel1043 added this to the next-release milestone Aug 21, 2024
@jedel1043 jedel1043 requested a review from a team August 21, 2024 04:03
@nekevss nekevss added this pull request to the merge queue Aug 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 21, 2024
@nekevss nekevss added this pull request to the merge queue Aug 21, 2024
Merged via the queue into boa-dev:main with commit 1c83ad1 Aug 21, 2024
14 checks passed
@hansl hansl deleted the fix-js-class-minor-bug branch August 21, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants