Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed all tests #286

Merged
merged 5 commits into from
Mar 30, 2020
Merged

Fixed all tests #286

merged 5 commits into from
Mar 30, 2020

Conversation

HalidOdat
Copy link
Member

Fixed all tests from the new parser #281

test result: ok. 127 passed; 0 failed; 1 ignored; 0 measured; 0 filtered out

🎉 🎉 🎉

Razican
Razican reviewed Mar 30, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very nice! check a bit my comments, it's mostly for me to understand everything :)

boa/src/exec/mod.rs Outdated Show resolved Hide resolved
boa/src/exec/mod.rs Show resolved Hide resolved
@jasonwilliams
Copy link
Member

Wow, good work!

Razican
Razican approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good to go for me :)

@Razican Razican merged commit 2b3f622 into boa-dev:parser Mar 30, 2020
@HalidOdat HalidOdat deleted the fix/all-tests branch April 13, 2020 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Razican Razican Razican approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HalidOdat @jasonwilliams @Razican