[Merged by Bors] - Add assertion to check that a break label is identified at compile-time #1852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1852 +/- ##
==========================================
- Coverage 55.57% 55.57% -0.01%
==========================================
Files 199 199
Lines 17760 17765 +5
==========================================
+ Hits 9871 9873 +2
- Misses 7889 7892 +3
Continue to review full report at Codecov.
|
Razican
approved these changes
Feb 21, 2022
Razican
requested review from
HalidOdat,
jasonwilliams,
RageKnify,
raskad and
jedel1043
bors bot
pushed a commit
that referenced
this pull request
Feb 21, 2022
…me (#1852) This PR changes the following: - Adds a check at compile time for the existence of a break label (this should be a syntax error in the future; refactor from panics to results in compile should be a separate PR) - Adds a test for break label existence in boa/tests 262 misses some fairly important JS parity issues and not performing this check eagerly can lead to other more severe issues during VM execution.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Razican
pushed a commit
that referenced
this pull request
Feb 21, 2022
…me (#1852) This PR changes the following: - Adds a check at compile time for the existence of a break label (this should be a syntax error in the future; refactor from panics to results in compile should be a separate PR) - Adds a test for break label existence in boa/tests 262 misses some fairly important JS parity issues and not performing this check eagerly can lead to other more severe issues during VM execution.
Razican
added
bug
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the following:
262 misses some fairly important JS parity issues and not performing this check eagerly can lead to other more severe issues during VM execution.