-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated the Test262 submodule #1499
Conversation
Test262 conformance changes:
Broken tests:
|
Benchmark for cb15ba6Click to view benchmark
|
Failing test: // CHECK#1
verifyNotConfigurable(Boolean, "prototype");
assert.throws(TypeError, () => {
delete Boolean.prototype;
}); Previous version of the same test: // CHECK#1
verifyNotConfigurable(Boolean, "prototype");
try {
if (delete Boolean.prototype !== false) {
$ERROR('#1: Boolean.prototype has the attribute DontDelete');
}
} catch (e) {
if (e instanceof Test262Error) throw e;
assert(e instanceof TypeError);
}
boa/boa/src/syntax/ast/node/operator/unary_op/mod.rs Lines 93 to 108 in 59c56c5
we don't consider strict mode when deleting. |
@jedel1043 I think we should leave fixing broken tests for a separate PR, we should create an issue for this to keep track of it :) |
Yep, just commenting to keep track on what we need to fix |
This updates the Test262 submodule to have the latest tests from the official suite.