Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement missing species getters #1331

Merged
merged 3 commits into from
Jun 18, 2021
Merged

Implement missing species getters #1331

merged 3 commits into from
Jun 18, 2021

Conversation

raskad
Copy link
Member

@raskad raskad commented Jun 16, 2021

Implement missing species getters:

  • get Array [ @@species ]
  • get Map [ @@species ]

Adjust species getter docs/format:

  • get Set [ @@species ]

@Razican
Copy link
Member

Razican commented Jun 17, 2021

Test262 conformance changes:

Test result master count PR count difference
Total 78,897 78,897 0
Passed 26,865 26,881 +16
Ignored 15,628 15,628 0
Failed 36,404 36,388 -16
Panics 0 0 0
Conformance 34.05% 34.07% +0.02%
Fixed tests:
test/built-ins/Array/Symbol.species/symbol-species.js [strict mode] (previously Failed)
test/built-ins/Array/Symbol.species/symbol-species.js (previously Failed)
test/built-ins/Array/Symbol.species/symbol-species-name.js [strict mode] (previously Failed)
test/built-ins/Array/Symbol.species/symbol-species-name.js (previously Failed)
test/built-ins/Array/Symbol.species/length.js [strict mode] (previously Failed)
test/built-ins/Array/Symbol.species/length.js (previously Failed)
test/built-ins/Array/Symbol.species/return-value.js [strict mode] (previously Failed)
test/built-ins/Array/Symbol.species/return-value.js (previously Failed)
test/built-ins/Map/Symbol.species/symbol-species.js [strict mode] (previously Failed)
test/built-ins/Map/Symbol.species/symbol-species.js (previously Failed)
test/built-ins/Map/Symbol.species/symbol-species-name.js [strict mode] (previously Failed)
test/built-ins/Map/Symbol.species/symbol-species-name.js (previously Failed)
test/built-ins/Map/Symbol.species/length.js [strict mode] (previously Failed)
test/built-ins/Map/Symbol.species/length.js (previously Failed)
test/built-ins/Map/Symbol.species/return-value.js [strict mode] (previously Failed)
test/built-ins/Map/Symbol.species/return-value.js (previously Failed)

Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank! Looks very good :)

@Razican Razican merged commit 0825fda into boa-dev:master Jun 18, 2021
@raskad raskad deleted the species branch August 14, 2021 00:32
@Razican Razican added builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request labels Aug 24, 2021
@Razican Razican added this to the v0.13.0 milestone Aug 24, 2021
@raskad raskad mentioned this pull request Sep 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
builtins PRs and Issues related to builtins/intrinsics enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants