Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support overriding the arguments variable #1049

Merged
merged 1 commit into from
Jan 9, 2021

Conversation

AnnikaCodes
Copy link
Contributor

@AnnikaCodes AnnikaCodes commented Jan 8, 2021

This eliminates a number of panics in the Test262 suite.

This Pull Request works on #817.

It changes the following:

  • allows name reuse when declaring the arguments variable

This eliminates a number of panics in the Test262 suite.
@codecov
Copy link

codecov bot commented Jan 8, 2021

Codecov Report

Merging #1049 (7097185) into master (624d03d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1049   +/-   ##
=======================================
  Coverage   58.31%   58.31%           
=======================================
  Files         172      172           
  Lines       12007    12007           
=======================================
  Hits         7002     7002           
  Misses       5005     5005           
Impacted Files Coverage Δ
boa/src/object/gcobject.rs 67.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 624d03d...7097185. Read the comment docs.

@RageKnify RageKnify added the execution Issues or PRs related to code execution label Jan 9, 2021
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I have another PR almost ready that complements this, and should reduce the count of panics too :)

Test262 conformance changes:

Test result master count PR count difference
Total 78,497 78,497 0
Passed 24,548 24,548 0
Ignored 15,585 15,585 0
Failed 38,364 38,364 0
Panics 45 28 -17
Conformance 31.27 31.27 0.00%

Looking very good!

@Razican Razican added this to the v0.11.0 milestone Jan 9, 2021
@Razican Razican merged commit c083c85 into boa-dev:master Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
execution Issues or PRs related to code execution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants