-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boa's start-up time getting hit with GC Allocation #3896
Comments
Raising the threshold at the below might help. Line 66 in fc2a6e0
|
Yeah I also think we should raise the default threshold and make it configurable from outside of |
We’re not able to set each property_table with a capacity right now due to the fact that for each template the inner shape is cloned from the first shape. We may need to set new root shapes here, each one having its own set of prototype storage capacity and property capacity. @HalidOdat thoughts? |
Boa spends a large proportion of time in realm creation comparitive to actually running the code.
It seems a lot of this is due to building out the global objects on the heap and storing them causing the GC to do multiple collections before the program has even started.
We may wish to look at some sort of snapshot for built-ins or staticlly storing them somewhere (switch of GC for built-ins)
You can load the below profiler into ui.perfetto.dev or chrome developer tools and take a look.
![image](https://private-user-images.githubusercontent.com/936006/346354499-a7a178d6-3d6a-47b9-97a0-38d150c94779.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk0MjMwNjIsIm5iZiI6MTczOTQyMjc2MiwicGF0aCI6Ii85MzYwMDYvMzQ2MzU0NDk5LWE3YTE3OGQ2LTNkNmEtNDdiOS05N2EwLTM4ZDE1MGM5NDc3OS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxM1QwNDU5MjJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0xN2I3MDdmNzFkNDVlZjdmMjAxMDkzOTNmYTNlODU0Y2FhMmQzOGE2MDIyMTRiODhhMTQyMDU0MjFiNmYwNjhjJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.EDb5PbY1ppnxe_HYRCbZVvz5Hn2kTe1n9xglyl1jzMo)
chrome_profiler.json
The text was updated successfully, but these errors were encountered: