-
-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labeled if
statement
#2295
Labels
Milestone
Comments
Ideally, all these should be treated as |
bors bot
pushed a commit
that referenced
this issue
Oct 22, 2022
This Pull Request changes the following: - Implements the `LabelledStatement` Parse node. - Removes `label` from all label-able items (switch, blocks and loop statements). - Adjusts parsing to the new AST. #2295 isn't fixed by this, but with this change it should be easier to fix.
bors bot
pushed a commit
that referenced
this issue
Jan 19, 2023
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel necessary. ---> This Pull Request addresses #2295, and another case that I came across when I was adding `Break` to the `ByteCompiler` I did have a question that came up during this regarding the spec. We currently don't implement the [BreakableStatement](https://tc39.es/ecma262/#prod-BreakableStatement). Any thoughts on whether we should be? Especially since `BreakableStatement` seems to be a bit of a inaccurate since `LabelledStatement` is breakable too. It changes the following: - Moves handling of label jump out of `compile_block` and into `compile_labelled`. - Adds a couple more tests to keep track of `LabelledStatement` breaks. Co-authored-by: Ness <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A slight twist on #2243 :
The text was updated successfully, but these errors were encountered: