chore: add ASCII check before convert Latin1 into str

boa-dev · Feb 8, 2025 · c9cf38f · c9cf38f
1 parent 3e2b90e
commit c9cf38f
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/core/engine/src/builtins/date/utils.rs b/core/engine/src/builtins/date/utils.rs
@@ -756,9 +756,13 @@ pub(super) fn parse_date(date: &JsString, hooks: &dyn HostHooks) -> Option<i64>
     let owned_js_str = date.as_str();
     let owned_string: String;
     let date = match owned_js_str.variant() {
-        JsStrVariant::Latin1(s) =>
-        // SAFETY: Since all characters are ASCII we can safely convert this into str.
-        unsafe { str::from_utf8_unchecked(s) },
+        JsStrVariant::Latin1(s) => {
+            if !s.is_ascii() {
+                return None;
+            }
+            // SAFETY: Since all characters are ASCII we can safely convert this into str.
+            unsafe { str::from_utf8_unchecked(s) }
+        }
         JsStrVariant::Utf16(s) => {
             owned_string = String::from_utf16(s).ok()?;
             if !owned_string.is_ascii() {