Fix remainder by zero (#882)

* Fix remainder by zero

* Address review comments

boa/src/builtins/bigint/tests.rs

@@ -370,3 +370,9 @@ fn division_by_zero() {
     let mut engine = Context::new();
     assert_throws(&mut engine, "1n/0n", "RangeError");
 }
+
+#[test]
+fn remainder_by_zero() {
+    let mut engine = Context::new();
+    assert_throws(&mut engine, "1n % 0n", "RangeError");
+}

boa/src/value/operations.rs

@@ -134,12 +134,21 @@ impl Value {
     pub fn rem(&self, other: &Self, ctx: &mut Context) -> Result<Value> {
         Ok(match (self, other) {
             // Fast path:
-            (Self::Integer(x), Self::Integer(y)) => Self::integer(x % *y),
+            (Self::Integer(x), Self::Integer(y)) => {
+                if *y == 0 {
+                    Self::nan()
+                } else {
+                    Self::integer(x % *y)
+                }
+            }
             (Self::Rational(x), Self::Rational(y)) => Self::rational(x % y),
             (Self::Integer(x), Self::Rational(y)) => Self::rational(f64::from(*x) % y),
             (Self::Rational(x), Self::Integer(y)) => Self::rational(x % f64::from(*y)),
 
             (Self::BigInt(ref a), Self::BigInt(ref b)) => {
+                if *b.as_inner() == BigInt::from(0) {
+                    return ctx.throw_range_error("BigInt division by zero");
+                }
                 Self::bigint(a.as_inner().clone() % b.as_inner().clone())
             }
 

boa/src/value/tests.rs

@@ -320,6 +320,24 @@ fn sub_string_and_number_object() {
     assert!(value.is_nan());
 }
 
+#[test]
+fn div_by_zero() {
+    let mut engine = Context::new();
+
+    let value = forward_val(&mut engine, "1 / 0").unwrap();
+    let value = value.to_number(&mut engine).unwrap();
+    assert!(value.is_infinite());
+}
+
+#[test]
+fn rem_by_zero() {
+    let mut engine = Context::new();
+
+    let value = forward_val(&mut engine, "1 % 0").unwrap();
+    let value = value.to_number(&mut engine).unwrap();
+    assert!(value.is_nan());
+}
+
 #[test]
 fn bitand_integer_and_integer() {
     let mut engine = Context::new();