Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.11 #6

Merged
merged 6 commits into from
Jan 14, 2021
Merged

v0.11 #6

merged 6 commits into from
Jan 14, 2021

Conversation

jasonwilliams
Copy link
Member

No description provided.

Copy link
Contributor

@RageKnify RageKnify left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 2 things I think could be changed.


## Test 262

Test262 is the implementation conformance test suite maintained by TC39. It's used by nearly all engines to measure how conformant they are to the specification. Boa pulls the tests in-tree and runs against PRs and on a nightly basis. Test262 doesn't sit still, so since the last release we've updated our reference to make sure we're running against the latest spec. You can find more about Test262 [here](https://github.com/tc39/test262).
Copy link
Contributor

@RageKnify RageKnify Jan 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the term nightly fits here, what do you think?

Suggested change
Test262 is the implementation conformance test suite maintained by TC39. It's used by nearly all engines to measure how conformant they are to the specification. Boa pulls the tests in-tree and runs against PRs and on a nightly basis. Test262 doesn't sit still, so since the last release we've updated our reference to make sure we're running against the latest spec. You can find more about Test262 [here](https://github.com/tc39/test262).
Test262 is the implementation conformance test suite maintained by TC39. It's used by nearly all engines to measure how conformant they are to the specification. Boa pulls the tests in-tree and runs them against all PRs. Test262 doesn't sit still, so since the last release we've updated our reference to make sure we're running against the latest spec. You can find more about Test262 [here](https://github.com/tc39/test262).

_posts/2021-01-10-boa-release-11.md Outdated Show resolved Hide resolved
Copy link
Member

@Razican Razican left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thanks for the work Jason. I have added some comments in places where I think it would be interesting to add more information.

Comment on lines 42 to 50
## Embedding examples

We are still working on what the public API should look like, some of these decisions are driven by feedback and the constant changing way which Boa works.
Not only you can run Boa against javascript today you can also embed your own objects and classes into the engine before it's ran.

We've offered an [example](https://github.com/boa-dev/boa/blob/master/boa/examples/classes.rs) to show how a class can be constructed in Rust then added to the environment before executing your scripts.
This should offer a great insight into how you can interop Rust with JavaScript by using Boa.

If there are any examples you would like added, please raise an issue on the main repository.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are missing some examples until boa-dev/boa#634 (or an equivalent PR) get merged. Should we add some code examples here? Or at least mention that using a Context we can register global functions, global classes and so on.

We could mention the Context::register_global_function(), Context::register_global_class() and Context::register_global_property() functions, to make our users understand how to extend Boa.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I like the sound of that

_posts/2021-01-10-boa-release-11.md Outdated Show resolved Hide resolved

Test262 is the implementation conformance test suite maintained by TC39. It's used by nearly all engines to measure how conformant they are to the specification. Boa pulls the tests in-tree and runs against PRs and on a nightly basis. Test262 doesn't sit still, so since the last release we've updated our reference to make sure we're running against the latest spec. You can find more about Test262 [here](https://github.com/tc39/test262).

Since v0.10 we have almost doubled on spec conformance, and reduced panics from hundreds to less than 50. A year ago Boa didn't even track itself against Test262 so it was difficult to know how compliant we were to the spec, today not only do we track all changes against Test262 but we can see progress on a PR to PR basis.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Since v0.10 we have almost doubled on spec conformance, and reduced panics from hundreds to less than 50. A year ago Boa didn't even track itself against Test262 so it was difficult to know how compliant we were to the spec, today not only do we track all changes against Test262 but we can see progress on a PR to PR basis.
Since v0.10 we have almost doubled on spec conformance, and reduced panics from hundreds to 25 (tracked in [#817](https://github.com/boa-dev/boa/issues/817)). A year ago Boa didn't even track itself against Test262 so it was difficult to know how compliant we were to the spec, today not only do we track all changes against Test262 but we can see progress on a PR to PR basis.

Comment on lines 64 to 66
## Thank You

Everything in this release has been such a huge effort, we thank everyone who contributed, whether it was features, fixes or raising bugs.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I would mention the contributors since the last release. Especially for the ones outside of the org, and the new memberships in the organization.

I would also add links to the good first issues and maybe also issues where help is wanted, so that potential contributors know where to start.

@jasonwilliams jasonwilliams merged commit 9f4dad0 into master Jan 14, 2021
@github-pages github-pages bot temporarily deployed to github-pages September 26, 2021 10:13 Inactive
@jasonwilliams jasonwilliams deleted the v011 branch October 5, 2021 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants