[R4R]refactor reconnection #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
force-pushed
the
reconnection
branch
3 times, most recently
from
f059af1 to
a925602
Compare
unclezoro
force-pushed
the
reconnection
branch
5 times, most recently
from
e479d8e to
6209628
Compare
unclezoro
force-pushed
the
reconnection
branch
from
6209628 to
c66b447
Compare
ackratos
approved these changes
Aug 19, 2019
HaoyangLiu
approved these changes
Aug 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
resolve #issue #83
To solve the reconnection failed when the network joggle in a sudden
Rationale
The issue is caused by
readroutineandwriteroutineworking on differentconnection.There could be a potential bug if still use state translate in
WsClient. So decide to refactor the reconnection code, and new a WsClient and start it when needed.Example
add an example CLI or API response...
Changes
Notable changes:
Preflight checks
Already reviewed by
...
Related issues
#83