cmd/utils: exit process if txlookuplimit flag is set #2000
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanBSC
reviewed
Nov 24, 2023
weiihann
force-pushed
the
v1.3.1-beta-txlookup
branch
from
8aa663f to
bb6e91f
Compare
weiihann
force-pushed
the
v1.3.1-beta-txlookup
branch
from
bb6e91f to
a430e2e
Compare
buddh0
previously approved these changes
Nov 24, 2023
buddh0
approved these changes
Nov 24, 2023
brilliant-lx
approved these changes
Nov 25, 2023
brilliant-lx
pushed a commit
that referenced
this pull request
Nov 30, 2023
brilliant-lx
pushed a commit
that referenced
this pull request
Dec 4, 2023
weiihann
added a commit
to weiihann/bsc
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Crash node and exit process if
--txlookuplimitflag is set instead ofhistory.transactions.Rationale
If users still use
--txlookuplimitwhich is deprecated instead ofhistory.transactions, then it maintains the default number of blocks to maintain the transaction index for. This may cause the node to unindex transactions, which would affect the performance.Refer to #1999 for more details.
Example
N/A
Changes
os.Exit(1), this ensures the log message is printed before exiting.