Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4844: All changes #1798

Closed
wants to merge 60 commits into from
Closed

4844: All changes #1798

wants to merge 60 commits into from

Conversation

emailtovamos
Copy link
Contributor

@emailtovamos emailtovamos commented Aug 3, 2023 •
edited
Loading

Description

Missing things that are undergoing:

  • Ensure the blob transaction goes through without errors: currently there's RLP-SSZ mismatch error.
  • Storage of blobs
  • Query functionality
  • P2P
  • Some more...

Rationale

tell us why we need these changes...

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

emailtovamos and others added 30 commits June 12, 2023 12:02
@emailtovamos
eip-4844: Blob Transaction type and KZGs
479a264
@brilliant-lx
Merge pull request #1723 from bnb-chain/develop
9ed95d8 
release: draft release v1.2.7
@emailtovamos
core: types package updates: block,receipt,signing
e03c351
@emailtovamos
core: core package gaspool & types
9938575
@emailtovamos
miner: worker.go changes
d9e5904
@emailtovamos
core: contracts and ExcessDataGas
ee9b939
@emailtovamos
internal: transaction args
396dd9a
@emailtovamos
core: state transition changes for data gas
9a6ee55
@emailtovamos
core: blockchain,evm,types,prefetch
c314052
@emailtovamos
core: transaction type and consensus parlia todo
465fb4c
@emailtovamos
eth: backend, accessor, gasprice changes
d55eae7
@emailtovamos
cmd: evm execution and transition + interfaces
e865e99
@emailtovamos
accounts: backends simulated changes
1272949
@emailtovamos
internal: ethapi api changes
216e455
@emailtovamos
miner: worker changes for PrefetchMining
ff04b10
@emailtovamos
les: backend and accessor changes
445e444
@emailtovamos
light: ord_util changes
14b4498
@emailtovamos
params: config changes with todo
43fd297
@emailtovamos
tests: state_test_util changes
9a8f79b
@emailtovamos
Merge branch 'master' into 4844
db7ff37
@emailtovamos
Merge pull request #1733 from emailtovamos/4844
b464af1 
Merge 4844 from fork to bsc 4844 branch
@emailtovamos
core: remaining genesis related changes
a3e5e54
@emailtovamos
core: all remaining 4844 changes with some todo
2f41323
@emailtovamos
consensus: Sidecar & BlockAndSidecars structs
ed0ed98
@emailtovamos
core: tx_pool changes
663608e
@emailtovamos
consensus: interface & implementation for sidecar
366251f
@emailtovamos
core: consensus changes and todos + conversion
8612c2d
@emailtovamos
miner: worker's sidecar related changes
d5b6907
@emailtovamos
core: side type change
d72beeb
@emailtovamos
signer: ToTransaction() change
1538ed9
MatusKysel
MatusKysel reviewed Aug 8, 2023
View reviewed changes
core/vm/contracts.go

// pointEvaluation implements the EIP-4844 point evaluation precompile
// to check if a value is part of a blob at a specific point with a KZG proof.
type pointEvaluation struct{}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also here, please stick with geth names kzgPointEvaluation

bnb-alexlucaci and others added 26 commits August 8, 2023 12:19
@bnb-alexlucaci
rawdb: added blob sidecar crud for bboltdb
146e392
@bnb-alexlucaci
rawdb: added blob sidecar crud for leveldb
c38b64c
@bnb-alexlucaci
rawdb: added some blob tests
b651d2e
@emailtovamos
rlp: bug fix attempt which isnt working
985a268
@emailtovamos
rlp: insync with go-ethereum
a5b0d01
@emailtovamos
ssz: remove all ssz
a6b66b9
@emailtovamos
core: chainid change of type as a test
7a3cbfa
@emailtovamos
core: logic change for encoding. todo: size exact
59a3083
@emailtovamos
core: remove decodeTypedMinimal
a45b5be
@emailtovamos
core: cleanup of comments and some code
b123b3d
@emailtovamos
Merge pull request #1825 from bnb-chain/4844-rlp-bug
3abe3e2 
Fixing of 4844 rlp bug
@emailtovamos
Merge branch 'feature/4844-blobs-storage' into 4844-add-saving
6919a8b
@emailtovamos
blob: create generic blob storage to store for now
f317325
@emailtovamos
eth68: implement eth68 without test
140fc1a
@emailtovamos
blob: placing blobdb
b1b9e64
@emailtovamos
core: excessdatagas bug fix
7df23b8
@emailtovamos
core: networktx as an attempt for bfix
bfa8c26
@emailtovamos
p2p: debug logs for bfix
f9a1f11
@emailtovamos
core: ignore excessdatagas check + debug logs
51befba
@emailtovamos
peer: sidecar propagation with todos
5214969
@emailtovamos
Merge pull request #1883 from bnb-chain/4844-broadcast
b5d3028 
4844 broadcasting of sidecar
@emailtovamos
blob: bug fix in decoding
24665e9
@emailtovamos
fetcher: sidecar fetcher code with todos
f3ca030
@emailtovamos
Merge pull request #1905 from bnb-chain/4844-broadcast
35b2652 
Sidecar Fetcher initial code implementation
@emailtovamos
eth: sidecar sanity check todo
7f18c92
@emailtovamos
Merge pull request #1924 from bnb-chain/4844-broadcast
1753a01 
eth: sidecar sanity check todo
@zzzckck
Copy link
Collaborator

zzzckck commented Apr 3, 2024

4844 implementation has redesigned and implemented in this PR: #2279

@zzzckck zzzckck closed this Apr 3, 2024
@zzzckck zzzckck deleted the 4844 branch August 22, 2024 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MatusKysel MatusKysel MatusKysel left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emailtovamos @zzzckck @MatusKysel @brilliant-lx @bnb-alexlucaci