Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement limit and meter initcode and push0 for shanghai upgrade #1433

Closed
wants to merge 6 commits into from

Conversation

sunny2022da
Copy link
Contributor

sunny2022da and others added 6 commits April 10, 2023 22:25
When the interpreter is configured to use extra-eips,
this change makes it so that all the opcodes are deep-copied,
to prevent accidental modification of the 'base' jumptable.

Original-auther: yihuang <[email protected]>
Co-authored-by: Martin Holst Swende <[email protected]>
* params: Add Shangai and Cancun blocks

* fix copy/paste error

Original-auther: Guillaume Ballet <[email protected]>

Co-authored-by: Martin Holst Swende <[email protected]>

* fix typo in Shanghai name

Co-authored-by: Martin Holst Swende <[email protected]>
Implementation of https://eips.ethereum.org/EIPS/eip-3860, limit and meter initcode.
This PR enables EIP-3860 as part of the Shanghai fork.

Original-author: Andrei Maiboroda <[email protected]>
Co-authored-by: [email protected] <[email protected]>
Co-authored-by: Martin Holst Swende <[email protected]>
Co-authored-by: Marius van der Wijden <[email protected]>
* core/vm: Implement PUSH0

* Move PUSH0 to enable3855

* Add method doc

Original-Author: Alex Beregszaszi <[email protected]>
@Mister-EA
Copy link
Contributor

So, if I understand correctly this PR only imports the code for Shanghai upgrade? The activation and testing of these EIPs will be done in a subsequent PR?

@sunny2022da
Copy link
Contributor Author

So, if I understand correctly this PR only imports the code for Shanghai upgrade? The activation and testing of these EIPs will be done in a subsequent PR?

Yes, this PR just port the EIP related patch and necessary dependencies. other related testing and activation will be added in subsequent PR.

However, we have an internal discussion that need to have more adaption changes considering the BSC-specific hardfork and implementation. So I would like to close this PR and submit a new one. Thanks!

@sunny2022da
Copy link
Contributor Author

Close this PR as more work required to be done for introducing these EIPs, will submit a new one for review later. Thanks

@sunny2022da sunny2022da deleted the sunny-sh branch April 11, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants