This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 14
dep: update deps that were reported in OSV issues #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Jan 12, 2023
unclezoro
reviewed
Jan 12, 2023
// PrivKeySecp256k1 implements PrivKey. | ||
type PrivKeySecp256k1 [32]byte | ||
// PrivKey implements PrivKey. | ||
type PrivKeySecp256k1 []byte |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the motivation to change from array to slice? Is it possible to have more than 32 or less than 32 bytes now?
unclezoro
reviewed
Jan 12, 2023
unclezoro
reviewed
Jan 12, 2023
unclezoro
reviewed
Jan 12, 2023
unclezoro
reviewed
Jan 12, 2023
unclezoro
approved these changes
Jan 12, 2023
HSG88
reviewed
Jan 13, 2023
@@ -1,23 +0,0 @@ | |||
// +build libsecp256k1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BSC use secp256k1_cgo.go
, which is removed in this PR, is it reasonable?
And crypto/secp256k1/secp256k1.go
uses btcd, which is nocgo
.
brilliant-lx
approved these changes
Jan 16, 2023
This was referenced Jan 28, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr updates some dependencies to newer versions.
Rationale
Some dependency was found in OSV-reported issues. update them for security.
refer: https://github.com/google/osv-scanner
Example
The following commits are used to verify the compatibility:
original: https://github.com/j75689/bnc-tendermint/blob/cf1e338824f9409876b85527f38f1948effd505f/crypto/secp256k1/secp256k1_internal_test.go#L1019
new: https://github.com/j75689/bnc-tendermint/blob/34773fd8f16c06c6f4119b178bc5a8b23b2dc3f2/crypto/secp256k1/secp256k1_internal_test.go#L1019
Changes
Notable changes: