This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
Fix consensus failure when remote signer drops #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unclezoro
reviewed
Dec 25, 2020
CHANGELOG.md
Outdated
|
|
||
|
|
||
| ## v0.31.5-binance.1 | ||
| *July 17th, 2019* | ||
|
|
||
| ### IMPROVEMENTS: | ||
| - [mempool] [\#100](https://github.com/binance-chain/bnc-tendermint/pull/100) add OnlyPersistent to config of mempool | ||
| - [mempool] [\#100](https://github.com/binance-chain/bnc-tendermint/pull/100) add OnlyPersistent to config of mempool | ||
| - [metrics] [\#96](https://github.com/binance-chain/bnc-tendermint/pull/96) monitor: add more metrics about p2p | ||
|
|
There was a problem hiding this comment.
Why change CHANGELOG here?
unclezoro
reviewed
Dec 25, 2020
consensus/state.go
Outdated
| @@ -31,6 +32,8 @@ var ( | |||
| ErrInvalidProposalPOLRound = errors.New("Error invalid proposal POL round") | |||
| ErrAddingVote = errors.New("Error adding vote") | |||
| ErrVoteHeightMismatch = errors.New("Error vote height mismatch") | |||
|
|
|||
| errPubKeyIsNotSet = errors.New("pubkey is not set. Look for \"Can't get private validator pubkey\" errors") | |||
There was a problem hiding this comment.
Use Upper case? Just follow other Err even though it is not used by other packages.
|
The name of this PR is too simple, please add a short description |
EnderCrypto
changed the title
|
please make the commit clean and readable |
EnderCrypto
force-pushed
the
remote_drop
branch
from
4ecc58e to
1e64ed7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit cherry-pick d85e2e52d; resolve conflict:
-.[privval] #4275 Fix consensus failure when remote signer drops (@melekes)
PR: tendermint/tendermint#4275
tendermint/tendermint@d85e2e5
Commit privval: if remote signer errors, don't retry
PR: Regression with chain catchup behavior introduced in commit 1000378 tendermint/tendermint#5112
tendermint/tendermint@9da308f
Commit cherry-pick 61ab6718e; resolve conflicts
PR: only retrieve pubkey once for all validators (partially fixes #4865) tendermint/tendermint#4895
Commit cherry-pick commit 5ba30e6f5; resolve conflict
PR: consensus: only call privValidator.GetPubKey once per block tendermint/tendermint#5143