Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

[R4R] #262 Fix tx search pagination #12

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Conversation

ackratos
Copy link
Contributor

@ackratos ackratos commented Nov 26, 2018

cosmos change bnb-chain/bnc-cosmos-sdk#19

  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGELOG_PENDING.md

@ackratos ackratos self-assigned this Nov 26, 2018
@ackratos ackratos changed the title #262 Fix tx search pagination [R4R] #262 Fix tx search pagination Nov 26, 2018
Copy link
Contributor

@darren-liu darren-liu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is that possible to propose this to tendermint team?

@ackratos
Copy link
Contributor Author

is that possible to propose this to tendermint team?

I have already done that in cosmos cosmos/cosmos-sdk#2730
Will change official tendermint as well

@ackratos ackratos merged commit d345772 into master Nov 27, 2018
ackratos added a commit that referenced this pull request Jan 31, 2019
commit 15ee704
Author: Cong Zhao <[email protected]>
Date:   Wed Jan 30 20:54:34 2019 +0800

    #121 second iteration

commit cd8a777
Author: Cong Zhao <[email protected]>
Date:   Thu Dec 13 15:24:08 2018 +0800

    #121 state sync mode

commit 53e8710
Merge: 3f17d89 551d864
Author: cong <[email protected]>
Date:   Mon Dec 24 10:19:23 2018 +0800

    Merge pull request #19 from BiJie/sentry

    [R4R]fix sentry node replay faild

commit 551d864
Author: fudongbai <[email protected]>
Date:   Mon Dec 24 10:06:49 2018 +0800

    fix sentry node replay faild

commit 3f17d89
Merge: 93d3b62 ddeee6c
Author: zjubfd <[email protected]>
Date:   Mon Dec 17 15:16:46 2018 +0800

    Merge pull request #18 from BiJie/nostate

    [R4R]validator do not verify hash when with no state

commit 93d3b62
Merge: a1ad253 dbeddbc
Author: zjubfd <[email protected]>
Date:   Mon Dec 17 15:16:32 2018 +0800

    Merge pull request #17 from BiJie/idmissing

    [R4R]fix reconnect id missing  ,resolve #16

commit ddeee6c
Author: fudongbai <[email protected]>
Date:   Mon Dec 17 15:00:46 2018 +0800

    validator do not verify hash when with no state

commit dbeddbc
Author: fudongbai <[email protected]>
Date:   Fri Dec 14 16:19:12 2018 +0800

    fix reconnect id missing

commit a1ad253
Merge: 451a393 a561225
Author: cong <[email protected]>
Date:   Fri Nov 30 15:07:50 2018 +0800

    Merge pull request #13 from BiJie/issue_262_pagination_testfix

    [R4R] #262 Fix tx search pagination test case

commit a561225
Author: Cong Zhao <[email protected]>
Date:   Fri Nov 30 15:05:03 2018 +0800

    #262 Fix tx search pagination test case

commit 451a393
Merge: d345772 44fcecc
Author: zjubfd <[email protected]>
Date:   Fri Nov 30 14:04:58 2018 +0800

    Merge pull request #8 from BiJie/sentrynode

    [R4R]support Sentry Node, add simple blockexecutor and  restrictPeers config param#7

commit 44fcecc
Author: fudongbai <[email protected]>
Date:   Wed Nov 28 16:58:20 2018 +0800

    add withAppStat param

commit d345772
Merge: 4f6dfec 0f8d95e
Author: cong <[email protected]>
Date:   Tue Nov 27 13:41:23 2018 +0800

    Merge pull request #12 from BiJie/issue262_pagination

    [R4R] #262 Fix tx search pagination

commit 0f8d95e
Author: Cong Zhao <[email protected]>
Date:   Mon Nov 26 10:48:39 2018 +0800

    #262 Fix tx search pagination

commit 4f6dfec
Merge: 6fad36f 2367603
Author: cong <[email protected]>
Date:   Fri Nov 23 10:15:15 2018 +0800

    Merge pull request #11 from BiJie/BlockTimeIota_config_fix

    disable BlockTimeIota

commit 2367603
Author: Cong Zhao <[email protected]>
Date:   Wed Nov 21 21:27:35 2018 +0800

    disable BlockTimeIota

commit 6fad36f
Merge: 759be18 74ced3b
Author: danliu <[email protected]>
Date:   Wed Nov 21 15:19:51 2018 +0800

    Merge pull request #10 from BiJie/feature/fix_test

    fix mempool test

commit 74ced3b
Author: yutianwu <[email protected]>
Date:   Wed Nov 21 15:15:38 2018 +0800

    fix mempool test

commit 759be18
Merge: cf1745a ed87b99
Author: danliu <[email protected]>
Date:   Wed Nov 21 15:01:36 2018 +0800

    Merge pull request #9 from BiJie/feature/change_default_params

    R4R: Change default params

commit ed87b99
Author: yutianwu <[email protected]>
Date:   Wed Nov 21 11:11:47 2018 +0800

    update comments

commit 15475b4
Author: yutianwu <[email protected]>
Date:   Wed Nov 21 11:08:37 2018 +0800

    change default params

commit cf1745a
Merge: 038d87b d5b5ea8
Author: danliu <[email protected]>
Date:   Thu Nov 15 19:05:38 2018 +0800

    Merge pull request #6 from BiJie/issue_bc280

    Make mempool reactor handles received msg asynchronously

commit d5b5ea8
Author: danliu <[email protected]>
Date:   Thu Nov 15 16:27:24 2018 +0800

    Make mempool reactor handles received msg asynchronously

commit 038d87b
Merge: 3821815 2363a81
Author: danliu <[email protected]>
Date:   Wed Nov 14 16:05:35 2018 +0800

    Merge pull request #5 from BiJie/dependency-fix

    fix client_golang and go-metrics dependency

commit 2363a81
Author: Cong Zhao <[email protected]>
Date:   Sat Nov 10 17:24:02 2018 +0800

    fix client_golang and go-metrics dependency

commit 3821815
Merge: 90eda9b 1701b9c
Author: danliu <[email protected]>
Date:   Thu Nov 8 19:17:01 2018 +0800

    Merge pull request #3 from BiJie/issue_bc218

    Add priority lock for CheckTx in mempool and ReCheck ABCI interface

commit 1701b9c
Author: danliu <[email protected]>
Date:   Thu Nov 8 16:11:17 2018 +0800

    Add priority lock for CheckTx in mempool and ReCheck ABCI interface

commit 90eda9b
Author: Ethan Buchman <[email protected]>
Date:   Wed Oct 17 22:09:48 2018 -0400

    changelog and version

commit 1ad379a
Author: Alessio Treglia <[email protected]>
Date:   Wed Oct 17 18:55:23 2018 -0700

    Update CHANGELOG_PENDING.md

commit 7220167
Author: Anton Kaliaev <[email protected]>
Date:   Mon Oct 15 06:28:41 2018 +0400

    set next validators along with validators while replay (#2637)

    Closes #2634

commit adf8cea
Author: Alessio Treglia <[email protected]>
Date:   Thu Oct 11 20:37:21 2018 -0700

    Pass nil to NewValidatorSet() when genesis file's Validators field is nil (#2617)

    Closes: #2616
ackratos added a commit that referenced this pull request Feb 21, 2019
commit 15ee704
Author: Cong Zhao <[email protected]>
Date:   Wed Jan 30 20:54:34 2019 +0800

    #121 second iteration

commit cd8a777
Author: Cong Zhao <[email protected]>
Date:   Thu Dec 13 15:24:08 2018 +0800

    #121 state sync mode

commit 53e8710
Merge: 3f17d89 551d864
Author: cong <[email protected]>
Date:   Mon Dec 24 10:19:23 2018 +0800

    Merge pull request #19 from BiJie/sentry

    [R4R]fix sentry node replay faild

commit 551d864
Author: fudongbai <[email protected]>
Date:   Mon Dec 24 10:06:49 2018 +0800

    fix sentry node replay faild

commit 3f17d89
Merge: 93d3b62 ddeee6c
Author: zjubfd <[email protected]>
Date:   Mon Dec 17 15:16:46 2018 +0800

    Merge pull request #18 from BiJie/nostate

    [R4R]validator do not verify hash when with no state

commit 93d3b62
Merge: a1ad253 dbeddbc
Author: zjubfd <[email protected]>
Date:   Mon Dec 17 15:16:32 2018 +0800

    Merge pull request #17 from BiJie/idmissing

    [R4R]fix reconnect id missing  ,resolve #16

commit ddeee6c
Author: fudongbai <[email protected]>
Date:   Mon Dec 17 15:00:46 2018 +0800

    validator do not verify hash when with no state

commit dbeddbc
Author: fudongbai <[email protected]>
Date:   Fri Dec 14 16:19:12 2018 +0800

    fix reconnect id missing

commit a1ad253
Merge: 451a393 a561225
Author: cong <[email protected]>
Date:   Fri Nov 30 15:07:50 2018 +0800

    Merge pull request #13 from BiJie/issue_262_pagination_testfix

    [R4R] #262 Fix tx search pagination test case

commit a561225
Author: Cong Zhao <[email protected]>
Date:   Fri Nov 30 15:05:03 2018 +0800

    #262 Fix tx search pagination test case

commit 451a393
Merge: d345772 44fcecc
Author: zjubfd <[email protected]>
Date:   Fri Nov 30 14:04:58 2018 +0800

    Merge pull request #8 from BiJie/sentrynode

    [R4R]support Sentry Node, add simple blockexecutor and  restrictPeers config param#7

commit 44fcecc
Author: fudongbai <[email protected]>
Date:   Wed Nov 28 16:58:20 2018 +0800

    add withAppStat param

commit d345772
Merge: 4f6dfec 0f8d95e
Author: cong <[email protected]>
Date:   Tue Nov 27 13:41:23 2018 +0800

    Merge pull request #12 from BiJie/issue262_pagination

    [R4R] #262 Fix tx search pagination

commit 0f8d95e
Author: Cong Zhao <[email protected]>
Date:   Mon Nov 26 10:48:39 2018 +0800

    #262 Fix tx search pagination

commit 4f6dfec
Merge: 6fad36f 2367603
Author: cong <[email protected]>
Date:   Fri Nov 23 10:15:15 2018 +0800

    Merge pull request #11 from BiJie/BlockTimeIota_config_fix

    disable BlockTimeIota

commit 2367603
Author: Cong Zhao <[email protected]>
Date:   Wed Nov 21 21:27:35 2018 +0800

    disable BlockTimeIota

commit 6fad36f
Merge: 759be18 74ced3b
Author: danliu <[email protected]>
Date:   Wed Nov 21 15:19:51 2018 +0800

    Merge pull request #10 from BiJie/feature/fix_test

    fix mempool test

commit 74ced3b
Author: yutianwu <[email protected]>
Date:   Wed Nov 21 15:15:38 2018 +0800

    fix mempool test

commit 759be18
Merge: cf1745a ed87b99
Author: danliu <[email protected]>
Date:   Wed Nov 21 15:01:36 2018 +0800

    Merge pull request #9 from BiJie/feature/change_default_params

    R4R: Change default params

commit ed87b99
Author: yutianwu <[email protected]>
Date:   Wed Nov 21 11:11:47 2018 +0800

    update comments

commit 15475b4
Author: yutianwu <[email protected]>
Date:   Wed Nov 21 11:08:37 2018 +0800

    change default params

commit cf1745a
Merge: 038d87b d5b5ea8
Author: danliu <[email protected]>
Date:   Thu Nov 15 19:05:38 2018 +0800

    Merge pull request #6 from BiJie/issue_bc280

    Make mempool reactor handles received msg asynchronously

commit d5b5ea8
Author: danliu <[email protected]>
Date:   Thu Nov 15 16:27:24 2018 +0800

    Make mempool reactor handles received msg asynchronously

commit 038d87b
Merge: 3821815 2363a81
Author: danliu <[email protected]>
Date:   Wed Nov 14 16:05:35 2018 +0800

    Merge pull request #5 from BiJie/dependency-fix

    fix client_golang and go-metrics dependency

commit 2363a81
Author: Cong Zhao <[email protected]>
Date:   Sat Nov 10 17:24:02 2018 +0800

    fix client_golang and go-metrics dependency

commit 3821815
Merge: 90eda9b 1701b9c
Author: danliu <[email protected]>
Date:   Thu Nov 8 19:17:01 2018 +0800

    Merge pull request #3 from BiJie/issue_bc218

    Add priority lock for CheckTx in mempool and ReCheck ABCI interface

commit 1701b9c
Author: danliu <[email protected]>
Date:   Thu Nov 8 16:11:17 2018 +0800

    Add priority lock for CheckTx in mempool and ReCheck ABCI interface

commit 90eda9b
Author: Ethan Buchman <[email protected]>
Date:   Wed Oct 17 22:09:48 2018 -0400

    changelog and version

commit 1ad379a
Author: Alessio Treglia <[email protected]>
Date:   Wed Oct 17 18:55:23 2018 -0700

    Update CHANGELOG_PENDING.md

commit 7220167
Author: Anton Kaliaev <[email protected]>
Date:   Mon Oct 15 06:28:41 2018 +0400

    set next validators along with validators while replay (#2637)

    Closes #2634

commit adf8cea
Author: Alessio Treglia <[email protected]>
Date:   Thu Oct 11 20:37:21 2018 -0700

    Pass nil to NewValidatorSet() when genesis file's Validators field is nil (#2617)

    Closes: #2616
ackratos added a commit that referenced this pull request Feb 27, 2019
commit 15ee704
Author: Cong Zhao <[email protected]>
Date:   Wed Jan 30 20:54:34 2019 +0800

    #121 second iteration

commit cd8a777
Author: Cong Zhao <[email protected]>
Date:   Thu Dec 13 15:24:08 2018 +0800

    #121 state sync mode

commit 53e8710
Merge: 3f17d89 551d864
Author: cong <[email protected]>
Date:   Mon Dec 24 10:19:23 2018 +0800

    Merge pull request #19 from BiJie/sentry

    [R4R]fix sentry node replay faild

commit 551d864
Author: fudongbai <[email protected]>
Date:   Mon Dec 24 10:06:49 2018 +0800

    fix sentry node replay faild

commit 3f17d89
Merge: 93d3b62 ddeee6c
Author: zjubfd <[email protected]>
Date:   Mon Dec 17 15:16:46 2018 +0800

    Merge pull request #18 from BiJie/nostate

    [R4R]validator do not verify hash when with no state

commit 93d3b62
Merge: a1ad253 dbeddbc
Author: zjubfd <[email protected]>
Date:   Mon Dec 17 15:16:32 2018 +0800

    Merge pull request #17 from BiJie/idmissing

    [R4R]fix reconnect id missing  ,resolve #16

commit ddeee6c
Author: fudongbai <[email protected]>
Date:   Mon Dec 17 15:00:46 2018 +0800

    validator do not verify hash when with no state

commit dbeddbc
Author: fudongbai <[email protected]>
Date:   Fri Dec 14 16:19:12 2018 +0800

    fix reconnect id missing

commit a1ad253
Merge: 451a393 a561225
Author: cong <[email protected]>
Date:   Fri Nov 30 15:07:50 2018 +0800

    Merge pull request #13 from BiJie/issue_262_pagination_testfix

    [R4R] #262 Fix tx search pagination test case

commit a561225
Author: Cong Zhao <[email protected]>
Date:   Fri Nov 30 15:05:03 2018 +0800

    #262 Fix tx search pagination test case

commit 451a393
Merge: d345772 44fcecc
Author: zjubfd <[email protected]>
Date:   Fri Nov 30 14:04:58 2018 +0800

    Merge pull request #8 from BiJie/sentrynode

    [R4R]support Sentry Node, add simple blockexecutor and  restrictPeers config param#7

commit 44fcecc
Author: fudongbai <[email protected]>
Date:   Wed Nov 28 16:58:20 2018 +0800

    add withAppStat param

commit d345772
Merge: 4f6dfec 0f8d95e
Author: cong <[email protected]>
Date:   Tue Nov 27 13:41:23 2018 +0800

    Merge pull request #12 from BiJie/issue262_pagination

    [R4R] #262 Fix tx search pagination

commit 0f8d95e
Author: Cong Zhao <[email protected]>
Date:   Mon Nov 26 10:48:39 2018 +0800

    #262 Fix tx search pagination

commit 4f6dfec
Merge: 6fad36f 2367603
Author: cong <[email protected]>
Date:   Fri Nov 23 10:15:15 2018 +0800

    Merge pull request #11 from BiJie/BlockTimeIota_config_fix

    disable BlockTimeIota

commit 2367603
Author: Cong Zhao <[email protected]>
Date:   Wed Nov 21 21:27:35 2018 +0800

    disable BlockTimeIota

commit 6fad36f
Merge: 759be18 74ced3b
Author: danliu <[email protected]>
Date:   Wed Nov 21 15:19:51 2018 +0800

    Merge pull request #10 from BiJie/feature/fix_test

    fix mempool test

commit 74ced3b
Author: yutianwu <[email protected]>
Date:   Wed Nov 21 15:15:38 2018 +0800

    fix mempool test

commit 759be18
Merge: cf1745a ed87b99
Author: danliu <[email protected]>
Date:   Wed Nov 21 15:01:36 2018 +0800

    Merge pull request #9 from BiJie/feature/change_default_params

    R4R: Change default params

commit ed87b99
Author: yutianwu <[email protected]>
Date:   Wed Nov 21 11:11:47 2018 +0800

    update comments

commit 15475b4
Author: yutianwu <[email protected]>
Date:   Wed Nov 21 11:08:37 2018 +0800

    change default params

commit cf1745a
Merge: 038d87b d5b5ea8
Author: danliu <[email protected]>
Date:   Thu Nov 15 19:05:38 2018 +0800

    Merge pull request #6 from BiJie/issue_bc280

    Make mempool reactor handles received msg asynchronously

commit d5b5ea8
Author: danliu <[email protected]>
Date:   Thu Nov 15 16:27:24 2018 +0800

    Make mempool reactor handles received msg asynchronously

commit 038d87b
Merge: 3821815 2363a81
Author: danliu <[email protected]>
Date:   Wed Nov 14 16:05:35 2018 +0800

    Merge pull request #5 from BiJie/dependency-fix

    fix client_golang and go-metrics dependency

commit 2363a81
Author: Cong Zhao <[email protected]>
Date:   Sat Nov 10 17:24:02 2018 +0800

    fix client_golang and go-metrics dependency

commit 3821815
Merge: 90eda9b 1701b9c
Author: danliu <[email protected]>
Date:   Thu Nov 8 19:17:01 2018 +0800

    Merge pull request #3 from BiJie/issue_bc218

    Add priority lock for CheckTx in mempool and ReCheck ABCI interface

commit 1701b9c
Author: danliu <[email protected]>
Date:   Thu Nov 8 16:11:17 2018 +0800

    Add priority lock for CheckTx in mempool and ReCheck ABCI interface

commit 90eda9b
Author: Ethan Buchman <[email protected]>
Date:   Wed Oct 17 22:09:48 2018 -0400

    changelog and version

commit 1ad379a
Author: Alessio Treglia <[email protected]>
Date:   Wed Oct 17 18:55:23 2018 -0700

    Update CHANGELOG_PENDING.md

commit 7220167
Author: Anton Kaliaev <[email protected]>
Date:   Mon Oct 15 06:28:41 2018 +0400

    set next validators along with validators while replay (#2637)

    Closes #2634

commit adf8cea
Author: Alessio Treglia <[email protected]>
Date:   Thu Oct 11 20:37:21 2018 -0700

    Pass nil to NewValidatorSet() when genesis file's Validators field is nil (#2617)

    Closes: #2616
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants