Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account ordering now matches web3.js #405

Merged
merged 2 commits into from
Jul 1, 2022

Conversation

tiago18c
Copy link
Member

@tiago18c tiago18c commented Jul 1, 2022

Status Type ⚠️ Core Change Issue
Ready Bug/Refactor Closes #397

Problem

Partial signing is incompatible with web3.js

Solution

Fixed account ordering to match web3.js.

Minor version bump instead of patch.

@tiago18c tiago18c requested a review from hoakbuilds July 1, 2022 16:09
Copy link
Member

@hoakbuilds hoakbuilds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFG

@tiago18c tiago18c merged commit c164d5d into bmresearch:master Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restore compatibility with web3.js on partial signing
2 participants