module: ignore package.json/ directories

Fixes: nodejs#8307
bmeck · Jan 19, 2018 · fec4a5d · fec4a5d
1 parent 1b0d979
commit fec4a5d
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 0 deletions.
diff --git a/lib/module.js b/lib/module.js
@@ -123,6 +123,10 @@ function readPackage(requestPath) {
     return entry;
 
   const jsonPath = path.resolve(requestPath, 'package.json');
+  const rc = stat(jsonPath);
+  if (rc !== 0) {
+    return false;
+  }
   const json = internalModuleReadJSON(path.toNamespacedPath(jsonPath));
 
   if (json === undefined) {

diff --git a/test/fixtures/module-package-json-directory/package.json/index.js b/test/fixtures/module-package-json-directory/package.json/index.js
diff --git a/test/parallel/test-require-package-json-directory.js b/test/parallel/test-require-package-json-directory.js
@@ -0,0 +1,13 @@
+'use strict';
+require('../common');
+const assert = require('assert');
+const fixtures = require('../common/fixtures');
+
+try {
+  require(fixtures.path('module-package-json-directory'));
+  process.exit(1);
+} catch (err) {
+  assert.ok(
+    /Cannot find module/.test(err.message),
+    `require() should ignore package.json/ directories: ${err.message}`);
+}