Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unit tests #345

Merged
merged 9 commits into from
Jan 31, 2025
Merged

Update unit tests #345

merged 9 commits into from
Jan 31, 2025

Conversation

prjemian
Copy link
Contributor

@prjemian prjemian added the bug label Jan 30, 2025
@prjemian prjemian added this to the v1.1.2 milestone Jan 30, 2025
@prjemian prjemian self-assigned this Jan 30, 2025
@prjemian prjemian requested review from mrakitin, padraic-shafer and a team January 30, 2025 22:01
Copy link
Contributor

@padraic-shafer padraic-shafer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look reasonable. I didn't spot any issues.

@prjemian prjemian merged commit 8490d37 into main Jan 31, 2025
8 checks passed
@prjemian prjemian deleted the 344-CI-maintenance branch January 31, 2025 00:19
- apischema
- black
- bluesky
- chardet
- databroker
- databroker <=1.999
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this approach! I use databroker <2.0.0b in our configs, but that will guarantee v2.0.0a won't get through :)

Copy link
Member

@mrakitin mrakitin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This got merged before I finished my review, but the changes look good, no issues were spotted either!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI needs maintenance
3 participants